]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
ALSA: hda: Drop useless WARN_ON()
authorTakashi Iwai <tiwai@suse.de>
Fri, 22 Dec 2017 09:45:07 +0000 (10:45 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 13 Mar 2018 10:29:41 +0000 (11:29 +0100)
commitc2d48cb49dc7b256c97867b435875d5d3410bd79
tree8b24553be42725ca57f98c6cfaf7c0fceae86a89
parent75078fdbbbe378ad5c263060c96065006f4793fc
ALSA: hda: Drop useless WARN_ON()

BugLink: http://bugs.launchpad.net/bugs/1745069
commit a36c2638380c0a4676647a1f553b70b20d3ebce1 upstream.

Since the commit 97cc2ed27e5a ("ALSA: hda - Fix yet another i915
pointer leftover in error path") cleared hdac_acomp pointer, the
WARN_ON() non-NULL check in snd_hdac_i915_register_notifier() may give
a false-positive warning, as the function gets called no matter
whether the component is registered or not.  For fixing it, let's get
rid of the spurious WARN_ON().

Fixes: 97cc2ed27e5a ("ALSA: hda - Fix yet another i915 pointer leftover in error path")
Reported-by: Kouta Okamoto <kouta.okamoto@toshiba.co.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/hda/hdac_i915.c