]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
audit: fix potential null dereference 'context->module.name'
authorYi Wang <wang.yi59@zte.com.cn>
Wed, 25 Jul 2018 02:26:19 +0000 (10:26 +0800)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:41:46 +0000 (19:41 -0600)
commitc3198f865c07fd0217259cb6c1146494453ed157
treebc75053ca179f7d5d477634f962b40858f7fded2
parent23f2bb2714d3aeade4c8ca355d2407deb5a20c65
audit: fix potential null dereference 'context->module.name'

BugLink: https://bugs.launchpad.net/bugs/1835845
commit b305f7ed0f4f494ad6f3ef5667501535d5a8fa31 upstream.

The variable 'context->module.name' may be null pointer when
kmalloc return null, so it's better to check it before using
to avoid null dereference.
Another one more thing this patch does is using kstrdup instead
of (kmalloc + strcpy), and signal a lost record via audit_log_lost.

Cc: stable@vger.kernel.org # 4.11
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
kernel/auditsc.c