]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
of: fix recursive locking in of_get_next_available_child()
authorStephen Warren <swarren@nvidia.com>
Mon, 11 Feb 2013 21:15:32 +0000 (14:15 -0700)
committerGrant Likely <grant.likely@secretlab.ca>
Wed, 13 Feb 2013 10:05:24 +0000 (10:05 +0000)
commitc31a0c052205e3ec24efc3fe18ef70c3e913f2d4
tree0c9a9bfea6fd494caefd714fb016a863fc253adf
parentbfc4a58986ba3934bb256ef3567aeeab262aa959
of: fix recursive locking in of_get_next_available_child()

of_get_next_available_child() acquires devtree_lock, then calls
of_device_is_available() which calls of_get_property() which calls
of_find_property() which tries to re-acquire devtree_lock, thus causing
deadlock.

To avoid this, create a new __of_device_is_available() which calls
__of_get_property() instead, which calls __of_find_property(), which
does not take the lock,. Update of_get_next_available_child() to call
the new __of_device_is_available() since it already owns the lock.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/of/base.c