]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
test_firmware: fix setting old custom fw path back on exit, second try
authorBen Hutchings <ben.hutchings@codethink.co.uk>
Wed, 4 Apr 2018 20:38:49 +0000 (22:38 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 14 Aug 2018 10:25:15 +0000 (12:25 +0200)
commitc33ccf8c0e6c998d9c8b5cff6c55b1af6b6d3ff8
tree6eb15f6367e219f4c450b906ddbb2c37c9d54fe8
parent20085505bcab013564f3ec051548543a9abf582d
test_firmware: fix setting old custom fw path back on exit, second try

BugLink: http://bugs.launchpad.net/bugs/1778759
commit e538409257d0217a9bc715686100a5328db75a15 upstream.

Commit 65c79230576 tried to clear the custom firmware path on exit by
writing a single space to the firmware_class.path parameter.  This
doesn't work because nothing strips this space from the value stored
and fw_get_filesystem_firmware() only ignores zero-length paths.

Instead, write a null byte.

Fixes: 0a8adf58475 ("test: add firmware_class loader test")
Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
tools/testing/selftests/firmware/fw_filesystem.sh