]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
rtc: pcf8563: Clear event flags and disable interrupts before requesting irq
authorChen-Yu Tsai <wens@csie.org>
Tue, 4 Jun 2019 04:23:36 +0000 (12:23 +0800)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
commitc3ca2be161097c2a3b273e41d23dcb8413144ed3
treeaa2c10e9278813e8a11df34c906a4fd96e459efd
parent030e82b73ca9b2b98d95d23c12b4dac8e1c43ae6
rtc: pcf8563: Clear event flags and disable interrupts before requesting irq

BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit 3572e8aea3bf925dac1dbf86127657c39fe5c254 ]

Besides the alarm, the PCF8563 also has a timer triggered interrupt.
In cases where the previous system left the timer and interrupts on,
or somehow the bits got enabled, the interrupt would keep triggering
as the kernel doesn't know about it.

Clear both the alarm and timer event flags, and disable the interrupts,
before requesting the interrupt line.

Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support")
Fixes: a45d528aab8b ("rtc: pcf8563: clear expired alarm at boot time")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/rtc/rtc-pcf8563.c