]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/amdgpu: Fix build with missing pm_suspend_target_state module export
authorBorislav Petkov <bp@suse.de>
Tue, 24 Aug 2021 09:42:47 +0000 (11:42 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 24 Aug 2021 15:57:44 +0000 (11:57 -0400)
commitc41a4e877a185241d8e83501453326fb98f67354
tree27e6eb2bb90f19bcc397dada3ce20ea86722eef2
parent32bc8f8373d2d6a681c96e4b25dca60d4d1c6016
drm/amdgpu: Fix build with missing pm_suspend_target_state module export

Building a randconfig here triggered:

  ERROR: modpost: "pm_suspend_target_state" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

because the module export of that symbol happens in
kernel/power/suspend.c which is enabled with CONFIG_SUSPEND.

The ifdef guards in amdgpu_acpi_is_s0ix_supported(), however, test for
CONFIG_PM_SLEEP which is defined like this:

  config PM_SLEEP
          def_bool y
          depends on SUSPEND || HIBERNATE_CALLBACKS

and that randconfig has:

  # CONFIG_SUSPEND is not set
  CONFIG_HIBERNATE_CALLBACKS=y

leading to the module export missing.

Change the ifdeffery to depend directly on CONFIG_SUSPEND.

Fixes: 5706cb3c910c ("drm/amdgpu: fix checking pmops when PM_SLEEP is not enabled")
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/YSP6Lv53QV0cOAsd@zn.tnic
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c