]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
xdp: remove memory poison on free for struct xdp_mem_allocator
authorJesper Dangaard Brouer <brouer@redhat.com>
Sat, 16 Nov 2019 11:22:38 +0000 (12:22 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Nov 2019 01:03:17 +0000 (17:03 -0800)
commitc491eae8f9c0720520ebdeb4d335671f84b84b71
tree1e73aa503c482accbead40e2d8fd28c78cfd0cf7
parentb95e86d846b63b02ecdc94802ddbeaf9005fb6d9
xdp: remove memory poison on free for struct xdp_mem_allocator

When looking at the details I realised that the memory poison in
__xdp_mem_allocator_rcu_free doesn't make sense. This is because the
SLUB allocator uses the first 16 bytes (on 64 bit), for its freelist,
which overlap with members in struct xdp_mem_allocator, that were
updated.  Thus, SLUB already does the "poisoning" for us.

I still believe that poisoning memory make sense in other cases.
Kernel have gained different use-after-free detection mechanism, but
enabling those is associated with a huge overhead. Experience is that
debugging facilities can change the timing so much, that that a race
condition will not be provoked when enabled. Thus, I'm still in favour
of poisoning memory where it makes sense.

Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/xdp.c