]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
arm64/mm: avoid fixmap race condition when create pud mapping
authorJianyong Wu <jianyong.wu@arm.com>
Tue, 1 Feb 2022 11:44:00 +0000 (19:44 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:37:56 +0000 (14:37 +0200)
commitc4a5f69839b4be0373939c339155c12fd07bdd4e
treed7be8af96cd1557c5b519c171031cd604f667c61
parent7ce41f090ca89b57a2c3a055e49d2e4185686095
arm64/mm: avoid fixmap race condition when create pud mapping

BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit ee017ee353506fcec58e481673e4331ff198a80e ]

The 'fixmap' is a global resource and is used recursively by
create pud mapping(), leading to a potential race condition in the
presence of a concurrent call to alloc_init_pud():

kernel_init thread                          virtio-mem workqueue thread
==================                          ===========================

  alloc_init_pud(...)                       alloc_init_pud(...)
  pudp = pud_set_fixmap_offset(...)         pudp = pud_set_fixmap_offset(...)
  READ_ONCE(*pudp)
  pud_clear_fixmap(...)
                                            READ_ONCE(*pudp) // CRASH!

As kernel may sleep during creating pud mapping, introduce a mutex lock to
serialise use of the fixmap entries by alloc_init_pud(). However, there is
no need for locking in early boot stage and it doesn't work well with
KASLR enabled when early boot. So, enable lock when system_state doesn't
equal to "SYSTEM_BOOTING".

Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Fixes: f4710445458c ("arm64: mm: use fixmap when creating page tables")
Link: https://lore.kernel.org/r/20220201114400.56885-1-jianyong.wu@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit c17eb1586c94d7a2bf72220566146232aaf16be0)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
arch/arm64/mm/mmu.c