]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
parport: remove non-zero check on count
authorColin Ian King <colin.king@canonical.com>
Fri, 30 Jul 2021 10:07:10 +0000 (11:07 +0100)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Tue, 12 Oct 2021 22:31:38 +0000 (16:31 -0600)
commitc4fff53907404901cd0c524074a2a4c57f514e78
tree01eb60f4af5b5b774ed3941b90f2e1dae2fb7e33
parentfdd0d9cecd7335c2e2e40619b6ed6676a38438b3
parport: remove non-zero check on count

BugLink: https://bugs.launchpad.net/bugs/1946802
[ Upstream commit 0be883a0d795d9146f5325de582584147dd0dcdc ]

The check for count appears to be incorrect since a non-zero count
check occurs a couple of statements earlier. Currently the check is
always false and the dev->port->irq != PARPORT_IRQ_NONE part of the
check is never tested and the if statement is dead-code. Fix this
by removing the check on count.

Note that this code is pre-git history, so I can't find a sha for
it.

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Logically dead code")
Link: https://lore.kernel.org/r/20210730100710.27405-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/parport/ieee1284_ops.c