]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
rxrpc: Use correct netns source in rxrpc_release_sock()
authorDavid Howells <dhowells@redhat.com>
Fri, 1 Dec 2017 11:09:53 +0000 (11:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 3 Dec 2017 15:05:20 +0000 (10:05 -0500)
commitc501256406fb19c306504ee1fe41a4ea208d4245
tree14e090180d35ba99251d712c2efb2e3abaa22d75
parent886afc1dc489436bf2c4fadf0f3aecacd7269234
rxrpc: Use correct netns source in rxrpc_release_sock()

In rxrpc_release_sock() there may be no rx->local value to access, so we
can't unconditionally follow it to the rxrpc network namespace information
to poke the connection reapers.

Instead, use the socket's namespace pointer to find the namespace.

This unfixed code causes the following static checker warning:

net/rxrpc/af_rxrpc.c:898 rxrpc_release_sock()
error: we previously assumed 'rx->local' could be null (see line 887)

Fixes: 3d18cbb7fd0c ("rxrpc: Fix conn expiry timers")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rxrpc/af_rxrpc.c