]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
pci: fix type warnings in intr_remapping.c
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 6 Aug 2010 18:02:31 +0000 (11:02 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 6 Aug 2010 18:02:31 +0000 (11:02 -0700)
commitc513b67e68787eceafeede32bcd0edbee45c0006
tree91affc9a29a20b339b3c88ae3ee1e99eba49dc2b
parent90c8327cad5d7c2d5d7d3e761d17af1925474107
pci: fix type warnings in intr_remapping.c

Commit 69309a059075 ("x86, asm: Clean up and simplify set_64bit()")
sanitized the x86-64 types to set_64bit(), and incidentally resulted in
warnings like

 drivers/pci/intr_remapping.c: In function 'modify_irte':
 drivers/pci/intr_remapping.c:314: warning: passing argument 1 of 'set_64bit' from incompatible pointer type
 arch/x86/include/asm/cmpxchg_64.h:6: note:expected 'volatile u64 *' but argument is of type 'long unsigned int *'

It turns out that the change to set_64bit() really does clean up things,
and the PCI intr_remapping.c file did a rather ugly cast in order to
avoid warnings with the previous set_64bit() type model.

Removing the ugly cast fixes the warning, and makes everybody happy and
expects a set_64bit() to take the logical "u64 *" argument.

Pointed-out-by: Peter Anvin <hpa@zytor.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/pci/intr_remapping.c