]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
xsk: fix to reject invalid options in Tx descriptor
authorBjörn Töpel <bjorn.topel@intel.com>
Fri, 8 Mar 2019 07:57:27 +0000 (08:57 +0100)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 8 Mar 2019 20:17:06 +0000 (21:17 +0100)
commitc57b557b644da624982c36b74f608cdb7b902868
treec3e8f92b4cb43f8db6c95003b39106e64c7db1cd
parentf54ba391d88f5a5d032175b4c308c176e34b80b7
xsk: fix to reject invalid options in Tx descriptor

Passing a non-existing option in the options member of struct
xdp_desc was, incorrectly, silently ignored. This patch addresses
that behavior, and drops any Tx descriptor with non-existing options.

We have examined existing user space code, and to our best knowledge,
no one is relying on the current incorrect behavior. AF_XDP is still
in its infancy, so from our perspective, the risk of breakage is very
low, and addressing this problem now is important.

Fixes: 35fcde7f8deb ("xsk: support for Tx")
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
net/xdp/xsk_queue.h