]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
drm/imx: imx-tve: Do not set the regulator voltage
authorFabio Estevam <fabio.estevam@nxp.com>
Wed, 8 Feb 2017 12:47:49 +0000 (10:47 -0200)
committerTim Gardner <tim.gardner@canonical.com>
Wed, 15 Mar 2017 15:32:11 +0000 (10:32 -0500)
commitc5c89c2ad8c7cdb030e4cc1de6fb5cefcc985871
treedd59164fe675703f3196b58f419008292798e2d2
parentff16bf18a774ff84e0ca4af55cb9d4e328a56de6
drm/imx: imx-tve: Do not set the regulator voltage

BugLink: http://bugs.launchpad.net/bugs/1673118
commit fc12bccda8b6f5c38139eceec9e369ed78091b2b upstream.

Commit deb65870b5d9d ("drm/imx: imx-tve: check the value returned by
regulator_set_voltage()") exposes the following probe issue:

63ff0000.tve supply dac not found, using dummy regulator
imx-drm display-subsystem: failed to bind 63ff0000.tve (ops imx_tve_ops): -22

When the 'dac-supply' is not passed in the device tree a dummy regulator is
used and setting its voltage is not allowed.

To fix this issue, do not set the dac-supply voltage inside the driver
and let its voltage be specified in the device tree.

Print a warning if the the 'dac-supply' voltage has a value different
from 2.75V.

Fixes: deb65870b5d9d ("drm/imx: imx-tve: check the value returned by regulator_set_voltage()")
Suggested-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/gpu/drm/imx/imx-tve.c