]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
geneve: use netlink_ext_ack for error reporting in rtnl operations
authorGirish Moodalbail <girish.moodalbail@oracle.com>
Wed, 9 Aug 2017 08:09:28 +0000 (01:09 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Aug 2017 20:45:02 +0000 (13:45 -0700)
commitc5ebc4409f2bb2c0b053c204ba197c6b71527eed
tree1dc3df096515f9e0c369af693e19fcab3a04002e
parentb50db91987fb1d4288ac8fdb7ba7487b352be6b5
geneve: use netlink_ext_ack for error reporting in rtnl operations

Add extack error messages for failure paths while creating/modifying
geneve devices. Once extack support is added to iproute2, more
meaningful and helpful error messages will be displayed making it easy
for users to discern what went wrong.

Before:

=======
$ ip link add gen1 address 0:1:2:3:4:5:6 type geneve id 200 \
  remote 192.168.13.2
RTNETLINK answers: Invalid argument

After:
======
$ ip link add gen1 address 0:1:2:3:4:5:6 type geneve id 200 \
  remote 192.168.13.2
Error: Provided link layer address is not Ethernet

Also, netdev_dbg() calls used to log errors associated with Netlink
request have been removed.

Signed-off-by: Girish Moodalbail <girish.moodalbail@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/geneve.c