]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
irq: mips: avoid nested irq_enter()
authorMark Rutland <mark.rutland@arm.com>
Wed, 20 Oct 2021 16:25:22 +0000 (17:25 +0100)
committerMark Rutland <mark.rutland@arm.com>
Mon, 25 Oct 2021 09:01:39 +0000 (10:01 +0100)
commitc65b52d02f6c1a06ddb20cba175ad49eccd6410d
treee57d3a036d3bcabc416bbae3a51042b5798367e2
parent9e1ff307c779ce1f0f810c7ecce3d95bbae40896
irq: mips: avoid nested irq_enter()

As bcm6345_l1_irq_handle() is a chained irqchip handler, it will be
invoked within the context of the root irqchip handler, which must have
entered IRQ context already.

When bcm6345_l1_irq_handle() calls arch/mips's do_IRQ() , this will nest
another call to irq_enter(), and the resulting nested increment to
`rcu_data.dynticks_nmi_nesting` will cause rcu_is_cpu_rrupt_from_idle()
to fail to identify wakeups from idle, resulting in failure to preempt,
and RCU stalls.

Chained irqchip handlers must invoke IRQ handlers by way of thee core
irqchip code, i.e. generic_handle_irq() or generic_handle_domain_irq()
and should not call do_IRQ(), which is intended only for root irqchip
handlers.

Fix bcm6345_l1_irq_handle() by calling generic_handle_irq() directly.

Fixes: c7c42ec2baa1de7a ("irqchips/bmips: Add bcm6345-l1 interrupt controller")
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Marc Zyngier <maz@kernel.org>
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
drivers/irqchip/irq-bcm6345-l1.c