]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
NFS: Forbid setting AF_INET6 to "struct sockaddr_in"->sin_family.
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sat, 30 Mar 2019 01:21:07 +0000 (10:21 +0900)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitc6bb31bbf4069e47f1dc9383105dbc0d201322ae
tree7d5594a0fa31b66f36505c089380b804d34b3cfc
parent3d9273c5cbf1cb8cfbbc339815c4f81c9a56dfa0
NFS: Forbid setting AF_INET6 to "struct sockaddr_in"->sin_family.

BugLink: https://bugs.launchpad.net/bugs/1838459
commit 7c2bd9a39845bfb6d72ddb55ce737650271f6f96 upstream.

syzbot is reporting uninitialized value at rpc_sockaddr2uaddr() [1]. This
is because syzbot is setting AF_INET6 to "struct sockaddr_in"->sin_family
(which is embedded into user-visible "struct nfs_mount_data" structure)
despite nfs23_validate_mount_data() cannot pass sizeof(struct sockaddr_in6)
bytes of AF_INET6 address to rpc_sockaddr2uaddr().

Since "struct nfs_mount_data" structure is user-visible, we can't change
"struct nfs_mount_data" to use "struct sockaddr_storage". Therefore,
assuming that everybody is using AF_INET family when passing address via
"struct nfs_mount_data"->addr, reject if its sin_family is not AF_INET.

[1] https://syzkaller.appspot.com/bug?id=599993614e7cbbf66bc2656a919ab2a95fb5d75c

Reported-by: syzbot <syzbot+047a11c361b872896a4f@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/nfs/super.c