]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
bnxt_en: Fix VLAN acceleration handling in bnxt_fix_features().
authorMichael Chan <michael.chan@broadcom.com>
Sun, 26 Apr 2020 20:24:42 +0000 (16:24 -0400)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Apr 2020 18:44:05 +0000 (11:44 -0700)
commitc72cb303aa6c2ae7e4184f0081c6d11bf03fb96b
tree09467be3cff764da866809026c4825eed414801b
parentbbf211b1ecb891c7e0cc7888834504183fc8b534
bnxt_en: Fix VLAN acceleration handling in bnxt_fix_features().

The current logic in bnxt_fix_features() will inadvertently turn on both
CTAG and STAG VLAN offload if the user tries to disable both.  Fix it
by checking that the user is trying to enable CTAG or STAG before
enabling both.  The logic is supposed to enable or disable both CTAG and
STAG together.

Fixes: 5a9f6b238e59 ("bnxt_en: Enable and disable RX CTAG and RX STAG VLAN acceleration together.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c