]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
netlink: remove the flex array from struct nlmsghdr
authorJakub Kicinski <kuba@kernel.org>
Fri, 18 Nov 2022 03:39:03 +0000 (19:39 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 19 Nov 2022 02:36:54 +0000 (18:36 -0800)
commitc73a72f4cbb47672c8cc7f7d7aba52f1cb15baca
treeb176e3501e520358e7303fcc94e796acc485b29d
parentab0377803dafc58f1e22296708c1c28e309414d6
netlink: remove the flex array from struct nlmsghdr

I've added a flex array to struct nlmsghdr in
commit 738136a0e375 ("netlink: split up copies in the ack construction")
to allow accessing the data easily. It leads to warnings with clang,
if user space wraps this structure into another struct and the flex
array is not at the end of the container.

Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/all/20221114023927.GA685@u2004-local/
Link: https://lore.kernel.org/r/20221118033903.1651026-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/uapi/linux/netlink.h
net/netlink/af_netlink.c