]> git.proxmox.com Git - mirror_qemu.git/commit
migration/ram: Handle RAM block resizes during precopy
authorDavid Hildenbrand <david@redhat.com>
Thu, 29 Apr 2021 11:27:02 +0000 (13:27 +0200)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Thu, 13 May 2021 17:21:13 +0000 (18:21 +0100)
commitc7c0e72408df5e7821c0e995122fb2fe0ac001f1
tree4328611e971fa50c3a0c8c16dade8431c5f72fcb
parente15c7d1e8c34bbffec2aa88f8fe7cd9812b1c71f
migration/ram: Handle RAM block resizes during precopy

Resizing while migrating is dangerous and does not work as expected.
The whole migration code works on the usable_length of ram blocks and does
not expect this to change at random points in time.

In the case of precopy, the ram block size must not change on the source,
after syncing the RAM block list in ram_save_setup(), so as long as the
guest is still running on the source.

Resizing can be trigger *after* (but not during) a reset in
ACPI code by the guest
- hw/arm/virt-acpi-build.c:acpi_ram_update()
- hw/i386/acpi-build.c:acpi_ram_update()

Use the ram block notifier to get notified about resizes. Let's simply
cancel migration and indicate the reason. We'll continue running on the
source. No harm done.

Update the documentation. Postcopy will be handled separately.

Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20210429112708.12291-5-david@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
  Manual merge
include/exec/memory.h
migration/migration.c
migration/migration.h
migration/ram.c
softmmu/physmem.c