]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
bus: ti-sysc: Fix watchdog quirk handling
authorTony Lindgren <tony@atomide.com>
Thu, 17 Oct 2019 18:21:44 +0000 (11:21 -0700)
committerTony Lindgren <tony@atomide.com>
Fri, 18 Oct 2019 15:45:32 +0000 (08:45 -0700)
commitc7d8669f46ba97f6a8e14d6e9b8d6c39e2c07727
treedd95cf5e0af1d35ff107643660cd40a5ba846bfd
parent54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c
bus: ti-sysc: Fix watchdog quirk handling

I noticed that when probed with ti-sysc, watchdog can trigger on am3, am4
and dra7 causing a device reset.

Turns out I made several mistakes implementing the watchdog quirk handling:

1. We must do both writes to spr register

2. We must also call the reset quirk on disable

3. On am3 and am4 we need to also set swsup quirk flag

I probably only tested this earlier with watchdog service running when the
watchdog never gets disabled.

Fixes: 4e23be473e30 ("bus: ti-sysc: Add support for module specific reset quirks")
Signed-off-by: Tony Lindgren <tony@atomide.com>
drivers/bus/ti-sysc.c