]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
arm64: vdso: fix clock_getres for 4GiB-aligned res
authorMark Rutland <mark.rutland@arm.com>
Mon, 30 Oct 2017 21:23:19 +0000 (21:23 +0000)
committerWill Deacon <will.deacon@arm.com>
Tue, 31 Oct 2017 09:49:33 +0000 (09:49 +0000)
commitc80ed088a519da53f27b798a69748eaabc66aadf
treec46b7d933904bf8dc37f1f2f05520ff54922c28c
parentfd9dde6abcb9bfe6c6bee48834e157999f113971
arm64: vdso: fix clock_getres for 4GiB-aligned res

The vdso tries to check for a NULL res pointer in __kernel_clock_getres,
but only checks the lower 32 bits as is uses CBZ on the W register the
res pointer is held in.

Thus, if the res pointer happened to be aligned to a 4GiB boundary, we'd
spuriously skip storing the timespec to it, while returning a zero error code
to the caller.

Prevent this by checking the whole pointer, using CBZ on the X register
the res pointer is held in.

Fixes: 9031fefde6f2ac1d ("arm64: VDSO support")
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reported-by: Andrew Pinski <apinski@cavium.com>
Reported-by: Mark Salyzyn <salyzyn@android.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/vdso/gettimeofday.S