]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
serial: 8250: Skip uninitialized TTY port baud rate update
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>
Wed, 23 Sep 2020 16:19:49 +0000 (19:19 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Sep 2020 12:52:42 +0000 (14:52 +0200)
commitc8dff3aa824177013d90967687f09f713a55d13f
tree09a8c2f7f3a7086343523b1202732fe6d6bef1ff
parent7718453e36960dadb8dc46f2b514b309659e1270
serial: 8250: Skip uninitialized TTY port baud rate update

It is erroneous to update the TTY port baud rate if it hasn't been
initialized yet, because in that case the TTY struct isn't set. So there
is no termios structure to get and re-calculate the baud if the current
baud can't be reached. Let's skip the baud rate update then until the port
is fully initialized.

Note the update UART clock method still sets the uartclk member with a new
ref clock value even if the port is turned off. The new UART ref clock
rate will be used later on the port starting up procedure.

Fixes: 868f3ee6e452 ("serial: 8250: Add 8250 port clock update method")
Tested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Link: https://lore.kernel.org/r/20200923161950.6237-3-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_port.c