]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_create_queue
authorJia-Ju Bai <baijiaju1990@gmail.com>
Tue, 10 Apr 2018 13:17:54 +0000 (21:17 +0800)
committerJon Mason <jdmason@kudzu.us>
Mon, 11 Jun 2018 19:20:59 +0000 (15:20 -0400)
commitc9160b69258ef46ab62c27a09decb8fef311e700
tree63e07b5afa240a6bd9201760cfa88fd3734bff25
parent82edcc758f273ed3afd308746dd69376d5b1024d
ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_create_queue

ntb_transport_create_queue() is never called in atomic context.

ntb_transport_create_queue() is only called by ntb_netdev_probe(),
which is set as ".probe" in struct ntb_transport_client.

Despite never getting called from atomic context,
ntb_transport_create_queue() calls kzalloc_node() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/ntb/ntb_transport.c