]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
ASoC: dapm: Fix possible uninitialized variable in snd_soc_dapm_get_volsw()
authorChen-Yu Tsai <wens@csie.org>
Sat, 27 Aug 2016 11:27:58 +0000 (19:27 +0800)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 8 Nov 2016 16:46:21 +0000 (16:46 +0000)
commitc9a9ee889e44d6e4014cd739aa45af3ab3bb689c
tree73802629b6ebf4bd2e9f87ab262c030900c98e7a
parent81192ef692ca378174671382fd5bc1991ed41bd0
ASoC: dapm: Fix possible uninitialized variable in snd_soc_dapm_get_volsw()

BugLink: http://bugs.launchpad.net/bugs/1638267
commit 01ad5e7de67b408d9b48b437b06a9938ddf460b5 upstream.

If soc_dapm_read() fails, val will be uninitialized, and bogus values
will be written later:

ret = soc_dapm_read(dapm, reg, &val);
val = (val >> shift) & mask;

However, the compiler does not give a warning. Return on error before
val is really used to avoid this.

This is similar to the commit 6912831623c5 ("ASoC: dapm: Fix
uninitialized variable in snd_soc_dapm_get_enum_double()")

Fixes: ce0fc93ae56e (ASoC: Add DAPM support at the component level)
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
sound/soc/soc-dapm.c