]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
net: usb: aqc111: Fix out-of-bounds accesses in RX fixup
authorMarcin Kozlowski <marcinguy@gmail.com>
Wed, 6 Apr 2022 08:05:37 +0000 (10:05 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 27 Apr 2022 10:00:56 +0000 (12:00 +0200)
commitc9b3b4924739eeab59ccbf1e1963f44e7a818d6b
treeec675d40c010eda328b4dc867c47414fa0b06ad8
parente5d43d44c1c477d1f169b6886bd6ea42d8239dc3
net: usb: aqc111: Fix out-of-bounds accesses in RX fixup

BugLink: https://bugs.launchpad.net/bugs/1969857
[ Upstream commit afb8e246527536848b9b4025b40e613edf776a9d ]

aqc111_rx_fixup() contains several out-of-bounds accesses that can be
triggered by a malicious (or defective) USB device, in particular:

 - The metadata array (desc_offset..desc_offset+2*pkt_count) can be out of bounds,
   causing OOB reads and (on big-endian systems) OOB endianness flips.
 - A packet can overlap the metadata array, causing a later OOB
   endianness flip to corrupt data used by a cloned SKB that has already
   been handed off into the network stack.
 - A packet SKB can be constructed whose tail is far beyond its end,
   causing out-of-bounds heap data to be considered part of the SKB's
   data.

Found doing variant analysis. Tested it with another driver (ax88179_178a), since
I don't have a aqc111 device to test it, but the code looks very similar.

Signed-off-by: Marcin Kozlowski <marcinguy@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/usb/aqc111.c