]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
platform/x86: thinkpad_acpi: Initialize local in_tablet_mode and type
authorDarren Hart <dvhart@linux.intel.com>
Wed, 14 Dec 2016 22:45:48 +0000 (14:45 -0800)
committerDarren Hart <dvhart@linux.intel.com>
Thu, 15 Dec 2016 20:31:48 +0000 (12:31 -0800)
commitcb2bf25145e0d2abef20f47dd2ae55bff97fd9cb
treebd4292ed1a5ce326849f3aef0c870d561df38d9c
parent1d161d4cd719ac498545c94805803af8af9b642f
platform/x86: thinkpad_acpi: Initialize local in_tablet_mode and type

linux-next reported in_tablet_mode and type may be used uninitialized
after:

b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into separate function")

This turns out to be a false positive as the pr_info call cannot be
reached if tp_features.hotkey_tablet (global scope) is 0, and
in_tablet_mode and type are assigned in both places
tp_features.hotkey_tablet is assigned.

Regardless, to make it explicit and avoid further reports, initialize
in_tablet_mode to 0 and type to NULL.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Lyude <lyude@redhat.com>
drivers/platform/x86/thinkpad_acpi.c