]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ASoC: soc-pcm: ignore un-needed mutex_unlock() case on soc_pcm_open()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 1 Oct 2020 01:32:48 +0000 (10:32 +0900)
committerMark Brown <broonie@kernel.org>
Thu, 1 Oct 2020 19:28:18 +0000 (20:28 +0100)
commitcb2fce94c84e2c2798dca45aa00d1e03294fab95
tree48833a217f4774c575e87c3240852c12a120571f
parent27f41dfebf226c74691b4b30527459417b6510e8
ASoC: soc-pcm: ignore un-needed mutex_unlock() case on soc_pcm_open()

commit 140a4532cdb8c ("ASoC: soc-pcm: add soc_pcm_clean() and call it
from soc_pcm_open/close()") switch to call soc_pcm_clean() on
soc_pcm_open() when rollback case.

But, it uses "goto err" (A) *before* mutex_lock() (B) when error of
snd_soc_pcm_component_pm_runtime_get().
The mutex_unlock() (C) is not needed in such case. This patch fix it.

static int soc_pcm_open(...)
{
...
ret = snd_soc_pcm_component_pm_runtime_get(rtd, substream);
if (ret < 0)
(A) goto err;

(B) mutex_lock_nested(...);
...
err:
(C) mutex_unlock(..);
...
}

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87k0waag44.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c