]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/i915: Remove stale asserts from i915_gem_find_active_request()
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 29 May 2018 13:29:18 +0000 (14:29 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 30 May 2018 11:11:10 +0000 (12:11 +0100)
commitcc7cc5343584d90e74b7c929ff2c9a2ec8b49cfe
tree30fcf04259903d7a41714777603c0307a93fe11f
parenta3db142829e68e2619207306a7b83e8ed47466a6
drm/i915: Remove stale asserts from i915_gem_find_active_request()

Since we use i915_gem_find_active_request() from inside
intel_engine_dump() and may call that at any time, we do not guarantee
that the engine is paused nor that the signal kthreads and irq handler
are suspended, so we cannot assert that the breadcrumb doesn't advance
and that the irq hasn't happened on another CPU signaling the request we
believe to be idle.

The second assert removed (that request->engine == engine) remains
valid, but is now more rigorously checked during retirement.

Fixes: f636edb214a5 ("drm/i915: Make i915_engine_info pretty printer to standalone")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180529132922.6831-1-chris@chris-wilson.co.uk
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
drivers/gpu/drm/i915/i915_gem.c