]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
wifi: ath: Silence memcpy run-time false positive warning
authorKees Cook <keescook@chromium.org>
Wed, 15 Feb 2023 18:31:38 +0000 (20:31 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 9 Aug 2023 09:37:55 +0000 (11:37 +0200)
commitcc9e1c039b5432e72f934b78ea149b0ab692be3a
treeec9af3ed7e35093c238e154a9a51969416437ccf
parent77e913d373214191cbfd109b4e22b581da5c72bb
wifi: ath: Silence memcpy run-time false positive warning

BugLink: https://bugs.launchpad.net/bugs/2028808
[ Upstream commit bfcc8ba45eb87bfaaff900bbad2b87b204899d41 ]

The memcpy() in ath_key_config() was attempting to write across
neighboring struct members in struct ath_keyval. Introduce a wrapping
struct_group, kv_values, to be the addressable target of the memcpy
without overflowing an individual member. Silences the false positive
run-time warning:

  memcpy: detected field-spanning write (size 32) of single field "hk.kv_val" at drivers/net/wireless/ath/key.c:506 (size 16)

Link: https://bbs.archlinux.org/viewtopic.php?id=282254
Cc: Kalle Valo <kvalo@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230210054310.never.554-kees@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/wireless/ath/ath.h
drivers/net/wireless/ath/key.c