]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
usb: typec: altmodes/displayport: Fix configure initial pin assignment
authorRD Babiera <rdbabiera@google.com>
Wed, 29 Mar 2023 21:51:59 +0000 (21:51 +0000)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Wed, 17 May 2023 11:33:58 +0000 (13:33 +0200)
commitccac6a4257e6383194d5bb01bcfa13c83432cb54
tree10bf43e2cf9511ba16c97aa79dafabe775f46457
parent1d1adcd717666c36fa5ce4466ab47a58cb49d7f3
usb: typec: altmodes/displayport: Fix configure initial pin assignment

BugLink: https://bugs.launchpad.net/bugs/2016879
commit eddebe39602efe631b83ff8d03f26eba12cfd760 upstream.

While determining the initial pin assignment to be sent in the configure
message, using the DP_PIN_ASSIGN_DP_ONLY_MASK mask causes the DFP_U to
send both Pin Assignment C and E when both are supported by the DFP_U and
UFP_U. The spec (Table 5-7 DFP_U Pin Assignment Selection Mandates,
VESA DisplayPort Alt Mode Standard v2.0) indicates that the DFP_U never
selects Pin Assignment E when Pin Assignment C is offered.

Update the DP_PIN_ASSIGN_DP_ONLY_MASK conditional to intially select only
Pin Assignment C if it is available.

Fixes: 0e3bb7d6894d ("usb: typec: Add driver for DisplayPort alternate mode")
Cc: stable@vger.kernel.org
Signed-off-by: RD Babiera <rdbabiera@google.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230329215159.2046932-1-rdbabiera@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/usb/typec/altmodes/displayport.c