]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
crypto: dh - Don't permit 'key' or 'g' size longer than 'p'
authorEric Biggers <ebiggers@google.com>
Mon, 6 Nov 2017 02:30:46 +0000 (18:30 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 10 Nov 2017 11:20:17 +0000 (19:20 +0800)
commitccd9888f14a8019c0bbdeeae758aba1f58693712
tree2e955d96c62a527a2ef03a70c261c52b9bac3f50
parent199512b1234f09e44d592153ec82b44212b2f0c4
crypto: dh - Don't permit 'key' or 'g' size longer than 'p'

The "qat-dh" DH implementation assumes that 'key' and 'g' can be copied
into a buffer with size 'p_size'.  However it was never checked that
that was actually the case, which most likely allowed users to cause a
buffer underflow via KEYCTL_DH_COMPUTE.

Fix this by updating crypto_dh_decode_key() to verify this precondition
for all DH implementations.

Fixes: c9839143ebbf ("crypto: qat - Add DH support")
Cc: <stable@vger.kernel.org> # v4.8+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/dh_helper.c