]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
vme: Fix wrong pointer utilization in ca91cx42_slave_get
authorAugusto Mecking Caringi <augustocaringi@gmail.com>
Tue, 10 Jan 2017 10:45:00 +0000 (10:45 +0000)
committerLuis Henriques <luis.henriques@canonical.com>
Fri, 20 Jan 2017 15:38:58 +0000 (15:38 +0000)
commitccee4ae17cc9206410c98b6d56191feb8c667b5d
treea51094908eaf12a9bd5508d18863f563a7e0c9fc
parentf80fbcb82d247f1830e372a279b0d90962bd0c15
vme: Fix wrong pointer utilization in ca91cx42_slave_get

BugLink: http://bugs.launchpad.net/bugs/1658091
commit c8a6a09c1c617402cc9254b2bc8da359a0347d75 upstream.

In ca91cx42_slave_get function, the value pointed by vme_base pointer is
set through:

*vme_base = ioread32(bridge->base + CA91CX42_VSI_BS[i]);

So it must be dereferenced to be used in calculation of pci_base:

*pci_base = (dma_addr_t)*vme_base + pci_offset;

This bug was caught thanks to the following gcc warning:

drivers/vme/bridges/vme_ca91cx42.c: In function ‘ca91cx42_slave_get’:
drivers/vme/bridges/vme_ca91cx42.c:467:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
*pci_base = (dma_addr_t)vme_base + pci_offset;

Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
Acked-By: Martyn Welch <martyn@welchs.me.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
drivers/vme/bridges/vme_ca91cx42.c