]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
tpm_tis: extra chip->ops check on error path in tpm_tis_core_init
authorVasily Averin <vvs@virtuozzo.com>
Sat, 13 Jun 2020 14:18:33 +0000 (17:18 +0300)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Thu, 2 Jul 2020 14:49:00 +0000 (17:49 +0300)
commitccf6fb858e17a8f8a914a1c6444d277cfedfeae6
treea9f693aa1d58d7b254ca882f0251a45d4d3a58ed
parenteac9347d932b96c09f089ac0673ebe588983e59b
tpm_tis: extra chip->ops check on error path in tpm_tis_core_init

Found by smatch:
drivers/char/tpm/tpm_tis_core.c:1088 tpm_tis_core_init() warn:
 variable dereferenced before check 'chip->ops' (see line 979)

'chip->ops' is assigned in the beginning of function
in tpmm_chip_alloc->tpm_chip_alloc
and is used before first possible goto to error path.

Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm_tis_core.c