]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
When a break signal is detected, the next character should be ignored.
authorMischa Jonker <mischa.jonker@nxp.com>
Thu, 15 Jan 2009 13:30:56 +0000 (13:30 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 15 Jan 2009 20:48:36 +0000 (12:48 -0800)
commitcd1e40f0981e22018373307cd4087dc876b08fb0
treec135e194063c85987aa0b36e41db4ed019bc3322
parent7fdd4f76e9a289592d020538f1837a7541ea89ff
When a break signal is detected, the next character should be ignored.

This was not implemented correctly for the pnx8xxx_uart driver.

[From further discussion:
Correct, you can look to it as two separate bugs:
a) the next character is not ignored while it should;
b) the status bits 31-8 are copied to the 'ch' variable while they shouldn't.

Both bugs prevent correct break signal handling (and therefore correct
behaviour of the magic SysRq key). Bug b didn't cause too much trouble
earlier because in most situations the status bits are all zero; for
this case they unfortunately aren't.
]

Signed-off-by: Mischa Jonker <mischa.jonker@nxp.com>
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/serial/pnx8xxx_uart.c