]> git.proxmox.com Git - mirror_frr.git/commit
ospfd: Fix ospfd crash in free_nexthop
authorChirag Shah <chirag@cumulusnetworks.com>
Tue, 15 Aug 2017 01:57:46 +0000 (18:57 -0700)
committerChirag Shah <chirag@cumulusnetworks.com>
Tue, 15 Aug 2017 14:47:08 +0000 (07:47 -0700)
commitcd4af52574ef8027b8d48989ee6445b6b2f246cc
treeeb781d66c15e15a69ba7b56f17db38120585ef69
parente2799b1d676022a00daf3e863ce494e33bbb1737
ospfd: Fix ospfd crash in free_nexthop

Fix ANVL-OSPF-5.1 reported ospfd crash.

vertex_nexthop_free was added as valgrind reported potential
memory leak, but in some cases nexthop would not be available
freed.
The actual nexthop free is part of ospf_canonical_nexthops_free(),
upon trying to free, qfree checks mtype count becomes 0 and asserts.
Removing vertex_nexthop_free() from ospf_spf_flush_parents().

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
ospfd/ospf_spf.c