]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
objtool: Print top level commands on incorrect usage
authorKamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Sat, 14 Oct 2017 14:47:54 +0000 (20:17 +0530)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Sat, 6 Jan 2018 12:22:39 +0000 (13:22 +0100)
commitcd75c9c55a5f288e1d3f20c48c5c4c2caf3966e8
tree74a3d09b5c395882d900a3a0a775bbd4fccc508e
parent869cbd2b31024e70d574527b8c6851bf2ebbe483
objtool: Print top level commands on incorrect usage

CVE-2017-5754

Print top-level objtool commands, along with the error on incorrect
command line usage. Objtool command line parser exit's with code 129,
for incorrect usage. Convert the cmd_usage() exit code also, to maintain
consistency across objtool.

After the patch:

  $ ./objtool -j

  Unknown option: -j

  usage: objtool COMMAND [ARGS]

  Commands:
     check   Perform stack metadata validation on an object file
     orc     Generate in-place ORC unwind tables for an object file

  $ echo $?
  129

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1507992474-16142-1-git-send-email-kamalesh@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
(cherry picked from commit 6a93bb7e4a7d6670677d5b0eb980936eb9cc5d2e)
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
tools/objtool/objtool.c