]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
gpio: pcf857x: Fix interrupts on multiple instances
authorRoger Quadros <rogerq@ti.com>
Wed, 9 Jan 2019 09:11:24 +0000 (11:11 +0200)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitcd8a5e06b393b483082f3710b347f5d232dd34df
tree2a35ef59865f0acc1ceedbeb9c2fbd693d36aa5f
parent1839b70a4650321fd9f4722f11b86a3797cf4c26
gpio: pcf857x: Fix interrupts on multiple instances

BugLink: https://bugs.launchpad.net/bugs/1837664
commit 2486e67374aa8b7854c2de32869642c2873b3d53 upstream.

When multiple instances of pcf857x chips are present, a fix up
message [1] is printed during the probe of the 2nd and later
instances.

The issue is that the driver is using the same irq_chip data
structure between multiple instances.

Fix this by allocating the irq_chip data structure per instance.

[1] fix up message addressed by this patch
[    1.212100] gpio gpiochip9: (pcf8575): detected irqchip that is shared with multiple gpiochips: please fix the driver.

Cc: Stable <stable@vger.kernel.org>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/gpio/gpio-pcf857x.c