]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ieee802154: Replace strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 13 Jun 2023 00:33:25 +0000 (00:33 +0000)
committerStefan Schmidt <stefan@datenfreihafen.org>
Fri, 16 Jun 2023 20:14:24 +0000 (22:14 +0200)
commitcd9125030689dda69f73f6c2843d63135cb383f0
tree4fffff073ceadecf1f0590d4a988999b769104f8
parentbd4e3d82f4ccb422672029b099e402e5b3acd5ee
ieee802154: Replace strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().

Direct replacement is safe here since the return values
from the helper macros are ignored by the callers.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230613003326.3538391-1-azeemshaikh38@gmail.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
net/ieee802154/trace.h
net/mac802154/trace.h