]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
sctp: fix the issue that the cookie-ack with auth can't get processed
authorXin Long <lucien.xin@gmail.com>
Wed, 2 May 2018 05:45:12 +0000 (13:45 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 2 May 2018 15:15:33 +0000 (11:15 -0400)
commitce402f044e4e432c296f90eaabb8dbe8f3624391
treece1cca0cfdfae502a233ad6e9848f7e74a03ef7c
parent46e16d4b956867013e0bbd7f2bad206f4aa55752
sctp: fix the issue that the cookie-ack with auth can't get processed

When auth is enabled for cookie-ack chunk, in sctp_inq_pop, sctp
processes auth chunk first, then continues to the next chunk in
this packet if chunk_end + chunk_hdr size < skb_tail_pointer().
Otherwise, it will go to the next packet or discard this chunk.

However, it missed the fact that cookie-ack chunk's size is equal
to chunk_hdr size, which couldn't match that check, and thus this
chunk would not get processed.

This patch fixes it by changing the check to chunk_end + chunk_hdr
size <= skb_tail_pointer().

Fixes: 26b87c788100 ("net: sctp: fix remote memory pressure from excessive queueing")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/inqueue.c