]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
net/smc: Prevent kernel-infoleak in __smc_diag_dump()
authorPeilin Ye <yepeilin.cs@gmail.com>
Thu, 20 Aug 2020 14:30:52 +0000 (16:30 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Aug 2020 19:07:31 +0000 (12:07 -0700)
commitce51f63e63c52a4e1eee4dd040fb0ba0af3b43ab
tree75d0baf07941877876df7f4fb99e3bb73551be9d
parent3e659a82c45076e354d20db4b0776e716c6e7fe3
net/smc: Prevent kernel-infoleak in __smc_diag_dump()

__smc_diag_dump() is potentially copying uninitialized kernel stack memory
into socket buffers, since the compiler may leave a 4-byte hole near the
beginning of `struct smcd_diag_dmbinfo`. Fix it by initializing `dinfo`
with memset().

Fixes: 4b1b7d3b30a6 ("net/smc: add SMC-D diag support")
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/smc/smc_diag.c