]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
target: Remove legacy + unused device active I/O shutdown code
authorNicholas Bellinger <nab@linux-iscsi.org>
Sun, 9 Oct 2011 09:19:01 +0000 (02:19 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Mon, 24 Oct 2011 03:20:59 +0000 (03:20 +0000)
commitce8762f6cd1e0e6d87a6d0b536635993aef0a697
treee59be88ea03a2b315afffad194a23b3ff1c652bc
parent8dc52b54207f361f7abf6cbe26f5199ae8b7cf23
target: Remove legacy + unused device active I/O shutdown code

This patch removes the legacy device active I/O shutdown code that was
originally called from transport_processing_thread() context during shutdown
including transport_processing_shutdown() and transport_release_all_cmds().

This is due to the fact that in modern configfs control plane code by the
time shutdown of an se_device instance in transport_processing_thread()
is allowed to occur via:

rmdir /sys/kernel/config/target/core/$HBA/$DEV

all active I/O will already have been ceased while removing active configfs
fabric Port/LUN symlinks.  Eg: the removal of an active se_device is protected
by inter-module VFS references from active Port/LUN symlinks.

Two WARN_ON() checks have been added in their place before exiting
transport_processing_thread() to watch out for any leaked descriptors.

Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c