]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
staging: vc04_services: make BCM_VIDEOCORE tristate
authorArnd Bergmann <arnd@arndb.de>
Mon, 20 Mar 2017 09:35:28 +0000 (10:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 21 Mar 2017 07:36:35 +0000 (08:36 +0100)
commitce95e3a9c59916d248df0a1a80494969777565df
tree5b8297f0950ebd9b3251e19b4ac211ea32e773e5
parent35060a228e70c712cb626ef3eabaedc40903eb77
staging: vc04_services: make BCM_VIDEOCORE tristate

Adding the 'bool' symbol brought back a randconfig build bug that
I had fixed before:

drivers/staging/built-in.o: In function `vchiq_probe':
(.text+0x1da30): undefined reference to `rpi_firmware_get'
drivers/staging/built-in.o: In function `vchiq_platform_init':
(.text+0x27494): undefined reference to `rpi_firmware_property'

The problem is that when RASPBERRYPI_FIRMWARE is a loadable module,
but BCM2835_VCHIQ can again be built-in. Making BCM_VIDEOCORE
itself tristate will make Kconfig honor the dependency correctly.

Fixes: 6bbfe4a76158 ("staging: vc04_services: Create new BCM_VIDEOCORE setting for VideoCore services.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/Kconfig