]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
atm: zatm: Fix potential Spectre v1
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 29 Jun 2018 18:28:07 +0000 (13:28 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sat, 30 Jun 2018 12:24:18 +0000 (21:24 +0900)
commitced9e191501e52b95e1b57b8e0db00943869eed0
tree4dd2099f5eabd75c7d66a217762edcffe8991df6
parentc7f653e0a8cf4e4a9951324f9b831cf88d813e48
atm: zatm: Fix potential Spectre v1

pool can be indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

drivers/atm/zatm.c:1491 zatm_ioctl() warn: potential spectre issue
'zatm_dev->pool_info' (local cap)

Fix this by sanitizing pool before using it to index
zatm_dev->pool_info

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/zatm.c