]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
mm: avoid returning VM_FAULT_RETRY from ->page_mkwrite handlers
authorJan Kara <jack@suse.cz>
Wed, 8 Feb 2017 22:30:53 +0000 (14:30 -0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 13 Mar 2018 10:26:48 +0000 (11:26 +0100)
commitcf2178e27ecd33f445b2787fd5b57abab18794ea
treefca5d19007a28bc852a4b49438f182c4054dd492
parent4d4682dfbc75749dd2b6106decdb83cd432a3af8
mm: avoid returning VM_FAULT_RETRY from ->page_mkwrite handlers

BugLink: http://bugs.launchpad.net/bugs/1745046
[ Upstream commit 0911d0041c22922228ca52a977d7b0b0159fee4b ]

Some ->page_mkwrite handlers may return VM_FAULT_RETRY as its return
code (GFS2 or Lustre can definitely do this).  However VM_FAULT_RETRY
from ->page_mkwrite is completely unhandled by the mm code and results
in locking and writeably mapping the page which definitely is not what
the caller wanted.

Fix Lustre and block_page_mkwrite_ret() used by other filesystems
(notably GFS2) to return VM_FAULT_NOPAGE instead which results in
bailing out from the fault code, the CPU then retries the access, and we
fault again effectively doing what the handler wanted.

Link: http://lkml.kernel.org/r/20170203150729.15863-1-jack@suse.cz
Signed-off-by: Jan Kara <jack@suse.cz>
Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/staging/lustre/lustre/llite/llite_mmap.c
include/linux/buffer_head.h