]> git.proxmox.com Git - mirror_qemu.git/commit
block/nvme: fix infinite loop in nvme_free_req_queue_cb()
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 8 Dec 2021 15:22:46 +0000 (15:22 +0000)
committerStefan Hajnoczi <stefanha@redhat.com>
Thu, 9 Dec 2021 09:19:49 +0000 (09:19 +0000)
commitcf4fbc3030c974fff726756a7ceef8386cdf500b
treeca6d09351156c279e124629f084dbe6c2de64445
parenta3607def89f9cd68c1b994e1030527df33aa91d0
block/nvme: fix infinite loop in nvme_free_req_queue_cb()

When the request free list is exhausted the coroutine waits on
q->free_req_queue for the next free request. Whenever a request is
completed a BH is scheduled to invoke nvme_free_req_queue_cb() and wake
up waiting coroutines.

1. nvme_get_free_req() waits for a free request:

    while (q->free_req_head == -1) {
        ...
            trace_nvme_free_req_queue_wait(q->s, q->index);
            qemu_co_queue_wait(&q->free_req_queue, &q->lock);
        ...
    }

2. nvme_free_req_queue_cb() wakes up the coroutine:

    while (qemu_co_enter_next(&q->free_req_queue, &q->lock)) {
       ^--- infinite loop when free_req_head == -1
    }

nvme_free_req_queue_cb() and the coroutine form an infinite loop when
q->free_req_head == -1. Fix this by checking q->free_req_head in
nvme_free_req_queue_cb(). If the free request list is exhausted, don't
wake waiting coroutines. Eventually an in-flight request will complete
and the BH will be scheduled again, guaranteeing forward progress.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20211208152246.244585-1-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/nvme.c