]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
mm: vma_adjust: remove superfluous confusing update in remove_next == 1 case
authorAndrea Arcangeli <aarcange@redhat.com>
Sat, 8 Oct 2016 00:01:25 +0000 (17:01 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 26 Jun 2017 10:07:27 +0000 (12:07 +0200)
commitcf83f7c9aa837b326620f806dfcf765ba89db07a
treec25ede31579528f9e030798a38be1c4b2405cb23
parentd11da519a4616c5deddf0eb7a06de7f5169b0ed2
mm: vma_adjust: remove superfluous confusing update in remove_next == 1 case

mm->highest_vm_end doesn't need any update.

After finally removing the oddness from vma_merge case 8 that was
causing:

1) constant risk of trouble whenever anybody would check vma fields
   from rmap_walks, like it happened when page migration was
   introduced and it read the vma->vm_page_prot from a rmap_walk

2) the callers of vma_merge to re-initialize any value different from
   the current vma, instead of vma_merge() more reliably returning a
   vma that already matches all fields passed as parameter

.. it is also worth to take the opportunity of cleaning up superfluous
code in vma_adjust(), that if not removed adds up to the hard
readability of the function.

Link: http://lkml.kernel.org/r/1474492522-2261-5-git-send-email-aarcange@redhat.com
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Jan Vorlicek <janvorli@microsoft.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
CVE-2017-1000364

(cherry-picked from commit fb8c41e9ad1f356b06b46a63ada10b7dce2a5d94)
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
mm/mmap.c