]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ext4: prevent right-shifting extents beyond EXT_MAX_BLOCKS
authorEric Biggers <ebiggers@google.com>
Thu, 12 Apr 2018 15:48:09 +0000 (11:48 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 14 Aug 2018 10:25:35 +0000 (12:25 +0200)
commitcf8917c526cc850e32edf94d842a1349667b34df
tree0999bd5d5c159a5e6aab3ee7bd126f61f85e6890
parent18dba5f5c0eb74c7c9ce6c3c72f01fe49440a773
ext4: prevent right-shifting extents beyond EXT_MAX_BLOCKS

BugLink: http://bugs.launchpad.net/bugs/1780499
commit 349fa7d6e1935f49bf4161c4900711b2989180a9 upstream.

During the "insert range" fallocate operation, extents starting at the
range offset are shifted "right" (to a higher file offset) by the range
length.  But, as shown by syzbot, it's not validated that this doesn't
cause extents to be shifted beyond EXT_MAX_BLOCKS.  In that case
->ee_block can wrap around, corrupting the extent tree.

Fix it by returning an error if the space between the end of the last
extent and EXT4_MAX_BLOCKS is smaller than the range being inserted.

This bug can be reproduced by running the following commands when the
current directory is on an ext4 filesystem with a 4k block size:

        fallocate -l 8192 file
        fallocate --keep-size -o 0xfffffffe000 -l 4096 -n file
        fallocate --insert-range -l 8192 file

Then after unmounting the filesystem, e2fsck reports corruption.

Reported-by: syzbot+06c885be0edcdaeab40c@syzkaller.appspotmail.com
Fixes: 331573febb6a ("ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate")
Cc: stable@vger.kernel.org # v4.2+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/ext4/extents.c