]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
net: dsa: qca8k: reset cpu port on MTU change
authorChristian Marangi <ansuelsmth@gmail.com>
Tue, 21 Jun 2022 15:11:22 +0000 (17:11 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 16 Sep 2022 08:52:21 +0000 (10:52 +0200)
commitcf9d75a78ba79012a7e5a2081a8e7d7408d0c3b5
tree6f4f15482bc47d5bce714e439f89490901ae02ec
parent3687588f1ac7d949071605abe152d8f5e4ea51bc
net: dsa: qca8k: reset cpu port on MTU change

BugLink: https://bugs.launchpad.net/bugs/1987451
commit 386228c694bf1e7a7688e44412cb33500b0ac585 upstream.

It was discovered that the Documentation lacks of a fundamental detail
on how to correctly change the MAX_FRAME_SIZE of the switch.

In fact if the MAX_FRAME_SIZE is changed while the cpu port is on, the
switch panics and cease to send any packet. This cause the mgmt ethernet
system to not receive any packet (the slow fallback still works) and
makes the device not reachable. To recover from this a switch reset is
required.

To correctly handle this, turn off the cpu ports before changing the
MAX_FRAME_SIZE and turn on again after the value is applied.

Fixes: f58d2598cf70 ("net: dsa: qca8k: implement the port MTU callbacks")
Cc: stable@vger.kernel.org
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: https://lore.kernel.org/r/20220621151122.10220-1-ansuelsmth@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/dsa/qca8k.c