]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
powerpc/eeh: Fix use of EEH_PE_KEEP on wrong field
authorSam Bobroff <sbobroff@linux.ibm.com>
Wed, 12 Sep 2018 01:23:22 +0000 (11:23 +1000)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:20:46 +0000 (14:20 -0300)
commitcfc59d5be53d76d045d1f11e1848079d4834529a
tree35c52fab13d49ded3417bb667f2813b11316767f
parent3ce64a79180ae84a69b1df07764605fb80f9d528
powerpc/eeh: Fix use of EEH_PE_KEEP on wrong field

BugLink: https://bugs.launchpad.net/bugs/1854975
[ Upstream commit 473af09b56dc4be68e4af33220ceca6be67aa60d ]

eeh_add_to_parent_pe() sometimes removes the EEH_PE_KEEP flag, but it
incorrectly removes it from pe->type, instead of pe->state.

However, rather than clearing it from the correct field, remove it.
Inspection of the code shows that it can't ever have had any effect
(even if it had been cleared from the correct field), because the
field is never tested after it is cleared by the statement in
question.

The clear statement was added by commit 807a827d4e74 ("powerpc/eeh:
Keep PE during hotplug"), but it didn't explain why it was necessary.

Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
arch/powerpc/kernel/eeh_pe.c