]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
staging: usbip: Fix deadlock
authorEric Lescouet <lescouet@virtuallogix.com>
Sat, 24 Apr 2010 00:55:24 +0000 (02:55 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 30 Apr 2010 16:30:10 +0000 (09:30 -0700)
commitd01f42a22ef381ba973958e977209ac9a8667d57
tree3e6f4736cda22c6be5d5d77ec489b44cfc53f499
parentc0087580b8d414f6874cfe93d2653212842fcb44
staging: usbip: Fix deadlock

When detaching a port from the client side (usbip --detach 0),
the event thread, on the server side, is going to deadlock.
The "eh" server thread is getting USBIP_EH_RESET event and calls:
  -> stub_device_reset() -> usb_reset_device()
the USB framework is then calling back _in the same "eh" thread_ :
  -> stub_disconnect() -> usbip_stop_eh() -> wait_for_completion()
the "eh" thread is being asleep forever, waiting for its own completion.
This patch checks if "eh" is the current thread, in usbip_stop_eh().

Signed-off-by: Eric Lescouet <eric@lescouet.org>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/usbip/usbip_event.c